Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix bothan config #476

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[Fix] fix bothan config #476

merged 1 commit into from
Nov 19, 2024

Conversation

colmazia
Copy link
Contributor

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI merged commit 6faf04a into extra/rest Nov 19, 2024
2 checks passed
@RogerKSI RogerKSI deleted the extra/rest-fix-bothan-config branch November 19, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerKSI RogerKSI RogerKSI approved these changes

@taobun taobun Awaiting requested review from taobun

@nkitlabs nkitlabs Awaiting requested review from nkitlabs

@satawatnack satawatnack Awaiting requested review from satawatnack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colmazia @RogerKSI