Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tables, emitter, flusher for group module #322

Closed
wants to merge 10 commits into from
Closed

Add tables, emitter, flusher for group module #322

wants to merge 10 commits into from

Conversation

RogerKSI
Copy link
Contributor

@RogerKSI RogerKSI commented Sep 1, 2023 •
edited
Loading

Implementation details

  • Add tables in Flusher for group module
  • Add hasura tracking for tables of group module
  • Add emitter and flusher logic
image

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@RogerKSI RogerKSI requested a review from colmazia September 1, 2023 10:13
colmazia
colmazia reviewed Sep 4, 2023
View reviewed changes
Copy link
Contributor

@colmazia colmazia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have 1 fix and several questions

flusher/flusher/db.py Outdated Show resolved Hide resolved
flusher/flusher/db.py Outdated Show resolved Hide resolved
flusher/flusher/db.py Outdated Show resolved Hide resolved
hasura/hasura-metadata/tables.yaml Show resolved Hide resolved
hasura/hasura-metadata/tables.yaml Show resolved Hide resolved
hasura/hasura-metadata/tables.yaml Show resolved Hide resolved
@RogerKSI RogerKSI requested a review from colmazia September 4, 2023 06:49
@RogerKSI RogerKSI marked this pull request as draft September 7, 2023 10:50
@RogerKSI RogerKSI requested review from taobun and satawatnack October 9, 2023 06:10
@RogerKSI RogerKSI marked this pull request as ready for review October 9, 2023 06:39
@RogerKSI RogerKSI changed the title Add tables for group module Add table, emitter, flusher for group module Oct 27, 2023
@RogerKSI RogerKSI changed the title Add table, emitter, flusher for group module Add tables, emitter, flusher for group module Oct 27, 2023
taobun
taobun requested changes Nov 30, 2023
View reviewed changes
hooks/emitter/handler.go Outdated Show resolved Hide resolved
app/app.go
app.OracleKeeper,
app.ICAHostKeeper,
app.IBCKeeper.ClientKeeper,
app.IBCKeeper.ConnectionKeeper,
app.IBCKeeper.ChannelKeeper,
keys[group.StoreKey],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why need to add just use storekey of group module directly?

Copy link
Contributor

@colmazia colmazia Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function that query proposal by voting period end is private so I have to use the storekey to query

hooks/emitter/group.go Outdated Show resolved Hide resolved
@colmazia colmazia requested a review from taobun December 4, 2023 08:59
@RogerKSI RogerKSI requested a review from colmazia December 13, 2023 06:53
@colmazia colmazia closed this Feb 27, 2024
@colmazia colmazia reopened this Feb 27, 2024
@colmazia colmazia closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satawatnack satawatnack Awaiting requested review from satawatnack

@taobun taobun Awaiting requested review from taobun

@colmazia colmazia Awaiting requested review from colmazia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerKSI @taobun @colmazia