use chain id as const string

bandprotocol · Sep 25, 2023 · b6364ab · b6364ab
1 parent 4990717
commit b6364ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/testing/testapp/setup.go b/testing/testapp/setup.go
@@ -86,6 +86,7 @@ var (
 )
 
 const (
+	ChainID               string = "BANDCHAIN"
 	TestDefaultPrepareGas uint64 = 40000
 	TestDefaultExecuteGas uint64 = 300000
 )
@@ -386,7 +387,7 @@ func NewTestApp(chainID string, logger log.Logger) *TestingApp {
 
 // CreateTestInput creates a new test environment for unit tests.
 func CreateTestInput(autoActivate bool) (*TestingApp, sdk.Context, keeper.Keeper) {
-	app := NewTestApp("BANDCHAIN", log.NewNopLogger())
+	app := NewTestApp(ChainID, log.NewNopLogger())
 	ctx := app.NewContext(false, tmproto.Header{Height: app.LastBlockHeight()})
 	if autoActivate {
 		app.OracleKeeper.Activate(ctx, Validators[0].ValAddress)
@@ -443,7 +444,7 @@ func setup(withGenesis bool, invCheckPeriod uint, chainID string) (*TestingApp,
 
 // SetupWithEmptyStore setup a TestingApp instance with empty DB
 func SetupWithEmptyStore() *TestingApp {
-	app, _, _ := setup(false, 0, "BANDCHAIN")
+	app, _, _ := setup(false, 0, ChainID)
 	return app
 }
 

diff --git a/x/oracle/simulation/operations_test.go b/x/oracle/simulation/operations_test.go
@@ -30,7 +30,7 @@ type SimTestSuite struct {
 func (suite *SimTestSuite) SetupTest() {
 	app, _, _ := testapp.CreateTestInput(true)
 	suite.app = app
-	suite.ctx = app.BaseApp.NewContext(false, tmproto.Header{ChainID: "BANDCHAIN"})
+	suite.ctx = app.BaseApp.NewContext(false, tmproto.Header{ChainID: testapp.ChainID})
 	s := rand.NewSource(1)
 	suite.r = rand.New(s)
 	suite.accs = suite.getTestingAccounts(suite.r, 10)
@@ -39,7 +39,7 @@ func (suite *SimTestSuite) SetupTest() {
 	suite.app.BeginBlock(
 		abci.RequestBeginBlock{
 			Header: tmproto.Header{
-				ChainID: "BANDCHAIN",
+				ChainID: testapp.ChainID,
 				Height:  suite.app.LastBlockHeight() + 1,
 				AppHash: suite.app.LastCommitID().Hash,
 			},