does not work

.eslintrc.js → .eslintrc.cjs

@@ -9,7 +9,6 @@ module.exports = {
 		// to avoid the `warning  Forbidden non-null assertion  @typescript-eslint/no-non-null-assertion`
 		'@typescript-eslint/no-non-null-assertion': 'off',
 		'@typescript-eslint/no-shadow': 'off',
-		'@typescript-eslint/no-var-requires': 'off',
 		'no-restricted-imports': [
 			'error',
 			{

.mocharc-standalone.js

@@ -1,4 +1,4 @@
-const commonConfig = require('./.mocharc.js');
+import commonConfig from './.mocharc.js';
 
 module.exports = {
 	...commonConfig,

automation/build-bin.ts

@@ -21,7 +21,7 @@ import { run as oclifRun } from '@oclif/core';
 import archiver from 'archiver';
 import Bluebird from 'bluebird';
 import { exec, execFile } from 'child_process';
-import * as filehound from 'filehound';
+import filehound from 'filehound';
 import type { Stats } from 'fs';
 import * as fs from 'fs-extra';
 import klaw from 'klaw';
@@ -31,14 +31,15 @@ import * as semver from 'semver';
 import { promisify } from 'util';
 import { notarize } from '@electron/notarize';
 
-import { stripIndent } from '../build/utils/lazy';
+import { stripIndent } from '../lib/utils/lazy';
 import {
 	diffLines,
 	loadPackageJson,
 	ROOT,
 	StdOutTap,
 	whichSpawn,
 } from './utils';
+import { filterCliOutputForTests, monochrome } from '../tests/helpers';
 
 const execFileAsync = promisify(execFile);
 const execAsync = promisify(exec);
@@ -87,7 +88,6 @@ export const finalReleaseAssets: { [platform: string]: string[] } = {
  * Throw an error if the diff is not empty.
  */
 async function diffPkgOutput(pkgOut: string) {
-	const { monochrome } = await import('../tests/helpers.js');
 	const relSavedPath = path.join(
 		'tests',
 		'test-data',
@@ -263,7 +263,6 @@ async function testPkg() {
 		'version',
 		'-j',
 	]);
-	const { filterCliOutputForTests } = await import('../tests/helpers.js');
 	const filtered = filterCliOutputForTests({
 		err: stderr.split(/\r?\n/),
 		out: stdout.split(/\r?\n/),
@@ -570,6 +569,8 @@ export async function testShrinkwrap(): Promise<void> {
 		console.error(`[debug] platform=${process.platform}`);
 	}
 	if (process.platform !== 'win32') {
-		await whichSpawn(path.resolve(__dirname, 'test-lock-deduplicated.sh'));
+		await whichSpawn(
+			path.resolve(import.meta.dirname, 'test-lock-deduplicated.sh'),
+		);
 	}
 }

automation/capitanodoc/capitanodoc.ts

@@ -144,7 +144,7 @@ capitanoDoc.categories.forEach((category) => {
  * for the documentation web page.
  */
 export async function getCapitanoDoc(): Promise<typeof capitanoDoc> {
-	const readmePath = path.join(__dirname, '..', '..', 'README.md');
+	const readmePath = path.join(import.meta.dirname, '..', '..', 'README.md');
 	const mdParser = new MarkdownFileParser(readmePath);
 	const sections: string[] = await Promise.all([
 		mdParser.getSectionOfTitle('About').then((sectionLines: string) => {

automation/capitanodoc/index.ts

@@ -19,6 +19,8 @@ import { getCapitanoDoc } from './capitanodoc';
 import type { Category, Document, OclifCommand } from './doc-types';
 import * as markdown from './markdown';
 import { stripIndent } from '../../lib/utils/lazy';
+import { createRequire } from 'node:module';
+const require = createRequire(import.meta.url);
 
 /**
  * Generates the markdown document (as a string) for the CLI documentation

automation/capitanodoc/markdown.ts

@@ -16,7 +16,7 @@
  */
 import { Parser } from '@oclif/core';
 import * as ent from 'ent';
-import * as _ from 'lodash';
+import _ from 'lodash';
 
 import { getManualSortCompareFunction } from '../../lib/utils/helpers';
 import { capitanoizeOclifUsage } from '../../lib/utils/oclif-utils';

automation/check-doc.ts

@@ -17,12 +17,12 @@
 
 // eslint-disable-next-line no-restricted-imports
 import { stripIndent } from 'common-tags';
-import * as _ from 'lodash';
+import _ from 'lodash';
 import { promises as fs } from 'fs';
 import * as path from 'path';
 import { simpleGit } from 'simple-git';
 
-const ROOT = path.normalize(path.join(__dirname, '..'));
+const ROOT = path.normalize(path.join(import.meta.dirname, '..'));
 
 /**
  * Compare the timestamp of balena-cli.md with the timestamp of staged files,

automation/check-npm-version.js

@@ -1,5 +1,6 @@
 #!/usr/bin/env node
 'use strict';
+import { execSync } from 'child_process';
 
 /**
  * Check that semver v1 is greater than or equal to semver v2.
@@ -36,7 +37,6 @@ function semverGte(v1, v2) {
 }
 
 function checkNpmVersion() {
-	const execSync = require('child_process').execSync;
 	const npmVersion = execSync('npm --version').toString().trim();
 	const requiredVersion = '6.9.0';
 	if (!semverGte(npmVersion, requiredVersion)) {

automation/deploy-bin.ts

@@ -15,20 +15,17 @@
  * limitations under the License.
  */
 
-import * as _ from 'lodash';
+import _ from 'lodash';
 import * as semver from 'semver';
+import { Octokit as OctokitLib } from '@octokit/rest';
+import OctoKitPluginThrottling from '@octokit/plugin-throttling';
+import parse from 'parse-link-header';
 
 const { GITHUB_TOKEN } = process.env;
 
 /** Return a cached Octokit instance, creating a new one as needed. */
 const getOctokit = _.once(function () {
-	const Octokit = (
-		require('@octokit/rest') as typeof import('@octokit/rest')
-	).Octokit.plugin(
-		(
-			require('@octokit/plugin-throttling') as typeof import('@octokit/plugin-throttling')
-		).throttling,
-	);
+	const Octokit = OctokitLib.plugin(OctoKitPluginThrottling.throttling);
 	return new Octokit({
 		auth: GITHUB_TOKEN,
 		throttle: {
@@ -73,8 +70,7 @@ function getPageNumbers(
 	if (!response.headers.link) {
 		return res;
 	}
-	const parse =
-		require('parse-link-header') as typeof import('parse-link-header');
+
 	const parsed = parse(response.headers.link);
 	if (parsed == null) {
 		throw new Error(`Failed to parse link header: '${response.headers.link}'`);

automation/run.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import * as _ from 'lodash';
+import _ from 'lodash';
 
 import {
 	buildOclifInstaller,
@@ -24,7 +24,7 @@ import {
 	signFilesForNotarization,
 	testShrinkwrap,
 } from './build-bin';
-import { updateDescriptionOfReleasesAffectedByIssue1359 } from './deploy-bin';
+import { updateDescriptionOfReleasesAffectedByIssue1359 } from './deploy-bin.js';
 
 // DEBUG set to falsy for negative values else is truthy
 process.env.DEBUG = ['0', 'no', 'false', '', undefined].includes(

automation/update-module.ts

@@ -54,7 +54,10 @@ interface Upstream {
 
 const getUpstreams = async () => {
 	const fs = await import('fs');
-	const repoYaml = fs.readFileSync(__dirname + '/../repo.yml', 'utf8');
+	const repoYaml = fs.readFileSync(
+		import.meta.dirname + '/../repo.yml',
+		'utf8',
+	);
 
 	const yaml = await import('js-yaml');
 	const { upstream } = yaml.load(repoYaml) as {

automation/utils.ts

@@ -17,8 +17,9 @@
 
 import { spawn } from 'child_process';
 import * as path from 'path';
+import { diffTrimmedLines } from 'diff';
 
-export const ROOT = path.join(__dirname, '..');
+export const ROOT = path.join(import.meta.dirname, '..');
 
 /** Tap and buffer this process' stdout and stderr */
 export class StdOutTap {
@@ -64,7 +65,6 @@ export class StdOutTap {
  * https://www.npmjs.com/package/diff
  */
 export function diffLines(str1: string, str2: string): string {
-	const { diffTrimmedLines } = require('diff');
 	const diffObjs = diffTrimmedLines(str1, str2);
 	const prefix = (chunk: string, char: string) =>
 		chunk

bin/dev.js

@@ -1,4 +1,4 @@
-#!/usr/bin/env node
+#!/usr/bin/env -S node --loader ts-node/esm --no-warnings=ExperimentalWarning
 
 // ****************************************************************************
 // THIS IS FOR DEV PURPOSES ONLY AND WILL NOT BE PART OF THE PUBLISHED PACKAGE
@@ -25,8 +25,9 @@ process.env.UV_THREADPOOL_SIZE = '64';
 //   is to use `balena-dev` without `fast-boot`. See also notes in
 //   `CONTRIBUTING.md`.
 
-const path = require('path');
-const rootDir = path.join(__dirname, '..');
+import * as path from 'path';
+import * as fs from 'fs';
+const rootDir = path.join(import.meta.dirname, '..');
 
 // Allow balena-dev to work with oclif by temporarily
 // pointing oclif config options to lib/ instead of build/
@@ -46,42 +47,44 @@ process.on('SIGINT', function () {
 });
 
 // Set the desired es version for downstream modules that support it
-require('@balena/es-version').set('es2018');
+(await import('@balena/es-version')).set('es2018');
 
 // Note: before ts-node v6.0.0, 'transpile-only' (no type checking) was the
 // default option. We upgraded ts-node and found that adding 'transpile-only'
 // was necessary to avoid a mysterious 'null' error message. On the plus side,
 // it is supposed to run faster. We still benefit from type checking when
 // running 'npm run build'.
-require('ts-node').register({
-	project: path.join(rootDir, 'tsconfig.json'),
-	transpileOnly: true,
+// (await import('ts-node')).register({
+// 	project: path.join(rootDir, 'tsconfig.json'),
+// 	transpileOnly: true,
+// });
+(await import('../lib/app.js')).run(undefined, {
+	dir: import.meta.url,
+	development: true,
 });
-require('../lib/app').run(undefined, { dir: __dirname, development: true });
 
 // Modify package.json oclif paths from build/ -> lib/, or vice versa
-function modifyOclifPaths(revert) {
-	const fs = require('fs');
-	const packageJsonPath = path.join(rootDir, 'package.json');
+// function modifyOclifPaths(revert) {
+// 	const packageJsonPath = path.join(rootDir, 'package.json');
 
-	const packageJson = fs.readFileSync(packageJsonPath, 'utf8');
-	const packageObj = JSON.parse(packageJson);
+// 	const packageJson = fs.readFileSync(packageJsonPath, 'utf8');
+// 	const packageObj = JSON.parse(packageJson);
 
-	if (!packageObj.oclif) {
-		return;
-	}
+// 	if (!packageObj.oclif) {
+// 		return;
+// 	}
 
-	let oclifSectionText = JSON.stringify(packageObj.oclif);
-	if (!revert) {
-		oclifSectionText = oclifSectionText.replace(/\/build\//g, '/lib/');
-	} else {
-		oclifSectionText = oclifSectionText.replace(/\/lib\//g, '/build/');
-	}
+// 	let oclifSectionText = JSON.stringify(packageObj.oclif);
+// 	if (!revert) {
+// 		oclifSectionText = oclifSectionText.replace(/\/build\//g, '/lib/');
+// 	} else {
+// 		oclifSectionText = oclifSectionText.replace(/\/lib\//g, '/build/');
+// 	}
 
-	packageObj.oclif = JSON.parse(oclifSectionText);
-	fs.writeFileSync(
-		packageJsonPath,
-		`${JSON.stringify(packageObj, null, 2)}\n`,
-		'utf8',
-	);
-}
+// 	packageObj.oclif = JSON.parse(oclifSectionText);
+// 	fs.writeFileSync(
+// 		packageJsonPath,
+// 		`${JSON.stringify(packageObj, null, 2)}\n`,
+// 		'utf8',
+// 	);
+// }

bin/run.js

@@ -1,21 +1,20 @@
-#!/usr/bin/env node
+#!/usr/bin/env -S node --loader ts-node/esm --no-warnings=ExperimentalWarning
 
 // We boost the threadpool size as ext2fs can deadlock with some
 // operations otherwise, if the pool runs out.
 process.env.UV_THREADPOOL_SIZE = '64';
 
-// Disable oclif registering ts-node
-process.env.OCLIF_TS_NODE = 0;
-
 async function run() {
 	// Use fast-boot to cache require lookups, speeding up startup
-	await require('../build/fast-boot').start();
+	await (await import('../build/lib/fast-boot.js')).start();
 
 	// Set the desired es version for downstream modules that support it
-	require('@balena/es-version').set('es2018');
+	(await import('@balena/es-version')).set('es2018');
 
 	// Run the CLI
-	await require('../build/app').run(undefined, { dir: __dirname });
+	await (
+		await import('../build/lib/app.js')
+	).run(undefined, { dir: import.meta.url });
 }
 
 run();

completion/generate-completion.js

@@ -15,9 +15,9 @@
  * limitations under the License.
  */
 
-const path = require('path');
-const rootDir = path.join(__dirname, '..');
-const fs = require('fs');
+import path from 'path';
+const rootDir = path.join(import.meta.dirname, '..');
+import fs from 'fs';
 const manifestFile = 'oclif.manifest.json';
 
 commandsFilePath = path.join(rootDir, manifestFile);
@@ -47,8 +47,8 @@ for (const key of Object.keys(commandsJson.commands).sort()) {
 const mainCommandsStr = mainCommands.join(' ');
 
 // GENERATE BASH COMPLETION FILE
-bashFilePathIn = path.join(__dirname, '/templates/bash.template');
-bashFilePathOut = path.join(__dirname, 'balena-completion.bash');
+bashFilePathIn = path.join(import.meta.dirname, '/templates/bash.template');
+bashFilePathOut = path.join(import.meta.dirname, 'balena-completion.bash');
 
 try {
 	fs.unlinkSync(bashFilePathOut);
@@ -109,8 +109,8 @@ fs.readFile(bashFilePathIn, 'utf8', function (err, data) {
 });
 
 // GENERATE ZSH COMPLETION FILE
-zshFilePathIn = path.join(__dirname, '/templates/zsh.template');
-zshFilePathOut = path.join(__dirname, '_balena');
+zshFilePathIn = path.join(import.meta.dirname, '/templates/zsh.template');
+zshFilePathOut = path.join(import.meta.dirname, '_balena');
 
 try {
 	fs.unlinkSync(zshFilePathOut);