Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment: AvalancheRootGaugeFactory V2 #79

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Deployment: AvalancheRootGaugeFactory V2 #79

merged 5 commits into from
Sep 4, 2023

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Sep 4, 2023

Deployment: AvalancheRootGaugeFactory V2

Deployment tasks checklist:

  • Contract(s) deployed to all target networks / testnets
  • TX IDs are properly generated
  • Action IDs are generated after deployment (if applicable)
  • Outputs for all target networks are generated, and linked in the task readme
  • Addresses files are up to date with the new deployment
  • Contracts are verified in every network
  • Deployments CHANGELOG is updated
  • There are no code changes of any kind

Issue Resolution

N/A.

EndymionJkb
EndymionJkb approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM. I checked to be sure the deprecated one was also in /addresses, and it was. (Must have been deprecated previously.)

@jubeira
Copy link
Contributor Author

jubeira commented Sep 4, 2023

I checked to be sure the deprecated one was also in /addresses, and it was. (Must have been deprecated previously.)

yeah so CI doesn't pass when you create the new task and move the old one to deprecated in the preparation stage.

@jubeira jubeira merged commit 7b4b3e1 into master Sep 4, 2023
29 checks passed
@jubeira jubeira deleted the deployment/avax-root-gauge-factory-v2 branch September 4, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @EndymionJkb