Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor verification fixes #120

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Minor verification fixes #120

merged 1 commit into from
Jul 7, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jul 2, 2024

Description

Some changes required as part of the V3 verification:

  • Update solidity verifier library (needed for some minor syntax changes in 0.8).
  • Accept '-' as part of the contract filenames inside build info (needed for some contracts that are in the dependencies).

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

Minor verification fixes:
0c3a1fa 
- Update solidity verifier library.
- Accept '-' as part of the contract filenames inside build info.
@jubeira jubeira requested a review from EndymionJkb July 2, 2024 20:26
EndymionJkb
EndymionJkb approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jubeira jubeira merged commit 87375b0 into master Jul 7, 2024
42 checks passed
@jubeira jubeira deleted the fix-verifier branch July 7, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EndymionJkb EndymionJkb EndymionJkb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @EndymionJkb