Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LZ OmniVotingEscrow (backport and Frax support) #119

Merged
merged 8 commits into from
Jun 20, 2024
Merged

LZ OmniVotingEscrow (backport and Frax support) #119

merged 8 commits into from
Jun 20, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jun 19, 2024

Description

Add tasks for LayerZero OmniVotingEscrow (mainnet) and OmniVotingEscrowChild.

The code for these contracts can be found here; they had been deployed a while ago, and we've been using them already (except for Frax which was missing).

This PR:

  • Manually adds the txs and addresses for already deployed contracts (i.e. OmniVotingEscrow in mainnet and OmniVotingEscrowChild in L2s except Frax)
  • Adds new Frax deployment for OmniVotingEscrowChild
  • Adds new Frax deployment for VeBoost V2 (which depends on OmniVotingEscrowChild)

Note: the code for OmniVotingEscrowChild is the same across all L2s. Base has a separate task because the license was modified after the initial deployment, which affects the resulting build info. Instead of redeploying with the 'original' build info, we have to keep it like this to preserve the same address across all networks. See individual tasks' READMEs for reference.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb June 19, 2024 16:17
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was waiting on CI (and re-ran one thing). Looks like all the pieces are there, as far as I can tell. Spot checked the addresses on multiple chains, and everything was verified and looked correct.

@jubeira jubeira merged commit 2b2ba69 into master Jun 20, 2024
42 checks passed
@jubeira jubeira deleted the lz-gauges branch June 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants