Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Fantom #113

Merged
merged 1 commit into from
May 7, 2024
Merged

Remove Fantom #113

merged 1 commit into from
May 7, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented May 3, 2024

Description

Fantom was added so as to give partial support to it in balpy, but only a few contracts were really untouched.
Since Fantom is under Beets' control and having it here collides with some automation around docs, it's better to just remove it.

The contracts are still deployed and usable of course; this is just to make documentation more consistent.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb May 3, 2024 21:46
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot leaner with all these old networks gone. Should we note in the changelog that we deleted rinkeby, kovan, goerli, and fantom networks? We have references to goerli in the logs still.

@jubeira jubeira merged commit e41b207 into master May 7, 2024
36 checks passed
@jubeira jubeira deleted the remove-fantom branch May 7, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants