Adding V3 pool roles #1200
Adding V3 pool roles #1200
Conversation
🦋 Changeset detectedLatest commit: 879d35e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| """ | ||
| Account empowered to set static swap fees for a pool (when 0 on V2 swap fees are immutable, on V3 delegate to governance) | ||
| """ | ||
| swapFeeManager: Bytes |
There was a problem hiding this comment.
not sure why this is bytes, lets make it string
There was a problem hiding this comment.
I guess Bytes naming comes from the contracts and it's meant to represent 0x strings. In TS it's just a String alias like BigDecimal is:
https://github.com/balancer/backend/blob/pool-roles/codegen.ts/#L15-L16
Maybe we should remove the mappings altogether to make it more understandable in the docs?
There was a problem hiding this comment.
agree, lets get rid of bytes and just use strings
There was a problem hiding this comment.
just change the owners to strings in the schema for now, leave the mapping as is
|
I would only change the owners types to string instead of bytes. Not sure why the owner was bytes before. Rest looks good |
it might be a consistency problem, because all other addresses are bytes as well. |
|
Ok. Lets leave it like this then and refactor another time 👍 |
closes #1086