Spec dispute documents #571
Conversation
|
Seems reasonable to me! |
|
Maybe we should add One more thing-- should |
|
I thought about this earlier today but I omitted it because I couldn't think of a reason we really needed to have it. It certainly doesn't really hurt anything to provide though.
|
| step 'I have debited a card that will initiate a dispute with submitted documents' | ||
| @dispute_id = nil | ||
| count = 60 | ||
| while @dispute_id.nil? and count > 0 |
There was a problem hiding this comment.
@remear what do you think about removing this polling shit and tasking someone to fix the dispute latency? this is a cancer across all our specs.
There was a problem hiding this comment.
Completely agree. This polling stuff horrible.
|
providing a e.g. i think that is a good idea personally. |
|
@tarunc Presently we're restricting file types to only: pdf, doc, jpg I'm going to clarify with @andrewnossiter about the doc vs docx requirement. As deduced from prior conversations, the processors only allow these 3 document types so no |
|
|
||
| Scenario: Retrieve a dispute document | ||
| Given I have a dispute with submitted documents | ||
| When I GET to /dispute_documents/:dispute_document_id |
There was a problem hiding this comment.
@steveklabnik do you like dispute_documents vs evidence? What's your reasoning for choosing one over the other?
There was a problem hiding this comment.
Pluralization of evidence was what steered me away from using it as a resource name.
There was a problem hiding this comment.
"evidence" can be evidence of anything, "dispute document" is extremely unambiguous.
I don't feel particularly strongly about it, though.
|
This looks gr8! Great job @remear |
|
Added file_size and changed file_type to mime_type with proposed allowed mime types. |
|
@balanced/engineers Any other adjustments? |
| "application/pdf", | ||
| "application/msword", | ||
| "application/vnd.openxmlformats-officedocument.wordprocessingml.document", | ||
| "image/jpeg" |
There was a problem hiding this comment.
pngs too? my mac creates a png everytime i take a screenshot
There was a problem hiding this comment.
In #563 (comment) it was stated that the only image format AMEX accepts is jpeg.
|
Dispute should have a ping @balanced/engineers Thoughts? |
|
Would probably have more context, disputed_documentation_submitted_at |
|
Yes. That's better. |
|
Should we create a github team called "spec-patrol" instead of engineers so it's not as noisy? |
|
|
| "properties": { | ||
| "links": { | ||
| "type": "object", | ||
| "properties": {} |
There was a problem hiding this comment.
this needs a dispute_document.dispute reference
|
@mahmoudimus @mjallday I didn't notice we had this spec for dispute document uploading, it looks like this is the spec for the API living in balanced service. But for now, justitia is an independent service. The json schema of justitia can be found here: https://github.com/balanced/justitia/tree/master/tests/fixtures/schemas So, should we mount corresponding URL endpoints in balanced API to justitia.balancedpayments.com? And should I modify justitia to make it works like this spec described? |
|
that's a good question @victorlin @mahmoudimus how do you envision api and disputes services interacting? is this disputes service mounted under the spec specifies a relative path for the dispute document - https://github.com/balanced/balanced-api/pull/571/files#diff-d8ae36f8a33d67242bf4cc1510101631R21 - i think we should tweak the pull-request and make those uris absolute instead. |
|
ping @mahmoudimus
What else needs to be done to complete the API spec? |
Spec-ing out dispute documents prior to implementation.
@steveklabnik Could you look over this first attempt.