Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify the error message when log_iw_size is too small #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions modules/afsocket/afsocket.c
Original file line number Diff line number Diff line change
Expand Up @@ -612,10 +612,9 @@ afsocket_sd_init(LogPipe *s)
self->reader_options.super.init_window_size /= self->max_connections;
if (self->reader_options.super.init_window_size < 100)
{
msg_warning("WARNING: window sizing for tcp sources were changed in syslog-ng 3.3, the configuration value was divided by the value of max-connections(). The result was too small, clamping to 100 entries. Ensure you have a proper log_fifo_size setting to avoid message loss.",
evt_tag_int("orig_log_iw_size", self->reader_options.super.init_window_size),
evt_tag_int("new_log_iw_size", 100),
evt_tag_int("min_log_fifo_size", 100 * self->max_connections),
msg_warning("WARNING: window sizing for tcp sources was changed in syslog-ng 3.3. log_iw_size divided by max-connections must be greater than 100. Ensure you have a proper log_iw_size to avoid message loss.",
evt_tag_int("orig_log_iw_size", self->reader_options.super.init_window_size * self->max_connections),
evt_tag_int("min_log_iw_size", 100 * self->max_connections),
NULL);
self->reader_options.super.init_window_size = 100;
}
Expand Down