Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arguments and paths for make_msa.sh #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alephreish
Copy link

@alephreish alephreish commented Oct 22, 2024

This fixes several issues in how make_msa.sh is run from preprocessing.py:

  • Enables non-empty database_params.sequencedb which in my interpretation was originally meant to provide the path to the database files
  • Makes it possible to use absolute paths for database_params.command
  • Fixes the bug in how subprocess.run() is used in preprocessing.py: it's a bad practice to create the entire command string by simply stitching together the command and the arguments. search_command = f"./{command} {fasta_file} {out_dir} {num_cpus} {ram_gb} {search_base} {template_database}" implied six arguments to make_msa.sh but the script in fact expected five: this issue was masked by the fact that search_base = model_runner.config.database_params.sequencedb is an empty string in base.yaml.
  • Fixes Error in the protein example #32

This commit does not fix several other issues in make_msa.sh: e.g. it breaks if any of the paths have spaces.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in the protein example
1 participant