Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor input/output types #232
Refactor input/output types #232
Changes from 1 commit
3188799
be863ef
3a14350
56dc07b
13802de
b9cd890
0bd4736
11cb62a
a514af7
43cfcf2
5b681c9
1e64a6f
5b860b6
c3d9632
16468cb
53663a1
ee17c5f
5a79f56
2566df6
96642c1
10c283d
e98161c
35aa35a
4e51e5a
b61fdf9
06a1558
c251fe1
0c3dafc
7220ffd
21b728e
2d8f7fb
138faae
a05beff
e4695a4
dfe9d8f
d3f9bb1
8bb1a19
a9d5c18
0d175c0
19bc197
8af5212
efec342
2e071c1
ca33389
137f219
5ab0ad1
bf57e19
0db3ea5
32bc451
f180073
e7ca9ac
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there still extra? And why is there pattern and input-pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise there would be breaking changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be fine, user base is small. What do you think @disrupted @raminqaf ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise we keep carrying technical debt because decision in the beginning weren't ideal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with it, but keep in mind we would have to do a major version bump for the next release, aka kpops 2.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, but we're not pre-release (0.x.x) anymore. Since we use semantic versioning we should follow its rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it is also fine to have v2 and quite soon v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, absolutely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Will carry out the breaking changes in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@philipp94831 I think I'm done with the changes to the code, what do you think?