Send screenshots with test results #37
Conversation
halinaVabishchevich
force-pushed
the
send-screenshots-with-test-results
branch
from
967cabb to
6ad12fb
Compare
…imple into send-screenshots-with-test-results # Conflicts: # package-lock.json # src/plugin.js
|
@halinaVabishchevich Hi, thank you for the pull request, could you resolve the conflicts before I take a look at it, please? |
Ready for review |
|
As someone whose company does not pay for Cypress Dashboard, this is very much appreciated. Anything I can do to help get this merged? |
|
Plus one to @treyturner 's earlier post. We'd love to get this incorporated, so open to helping in any way. Thanks! |
package.json
Outdated
| @@ -44,6 +44,9 @@ | |||
| "dependencies": { | |||
| "arg": "^5.0.1", | |||
| "debug": "^4.3.2", | |||
| "find": "^0.3.0", | |||
| "form-data": "^4.0.0", | |||
| "fs": "^0.0.1-security", | |||
There was a problem hiding this comment.
are you sure you meant to install this 3rd party module fs?
There was a problem hiding this comment.
Hey ! Thanks for the review and sorry for the late response
this one is fixed and also merged with main
ready to be reviewed again
|
@halinaVabishchevich Anything we can help out with to get this PR over the finish line? Looks like there might just be an extraneous, node-native dependency that can be removed ( |
…imple into send-screenshots-with-test-results # Conflicts: # package-lock.json # package.json
Add method
attachScreenshots:screenshotsfolderadd_attachment_to_resultapicypress-failed-logis added https://github.com/bahmutov/cypress-failed-log)getTestCommentsfunctionResult:
