-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support [Matrix] summary endpoint #10782
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this.
I've left a few comments but I think this draft is in pretty good shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nailed it - thanks
I'm going to deploy this shortly. I'm not sure if making the switch will be sufficient to get us unbanned from matrix.org or if we'll still be getting rejected on the summary endpoint as well? We'll have to wait and see what happens (which will take a while given we now have to wait ~4 hours for the existing badges to drop out of cache). |
Having done a quick test, I think the block only applies to guest account registration. These should start working again once the existing images expire from cache. |
|
||
const queryParamSchema = Joi.object({ | ||
server_fqdn: Joi.string().hostname(), | ||
fetchMode: Joi.string() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for fixing this!
any chance we can still make this snake_case without breaking the world, though? 🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the base attributes for shields badges use camel case.
'server_fqdn' should be camel case as well but that would be a breaking change, so that's how we ended up here ;)
Refs #10776
Implements support for matrix-org/matrix-spec-proposals#3266.
Can be configured with the new parameter
fetchMode
and is enforced formatrix.org
rooms.Combined with #10778 (increases cache duration by a factor of 480), the amount of requests is reduced by a factor of 1440!
The performance is much better than the current implementation (few test runs as an example):