Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #201: finish style guide design. #1

Merged

Conversation

ronnienorwood
Copy link
Contributor

Updating style guide design for backdrop/backdrop-issues#201 as part of rebranding the admin theme.

@jenlampton
Copy link
Member

The markup in the styleguide was generated by using a Backdrop port of the styleguide module so the column-formatting won't be preserved the next time we regenerate this guide.

That said, I do want to merge these changes so that we can see where we're at as far as choosing new styles. For now, this is our playground...

jenlampton added a commit that referenced this pull request Jan 9, 2015
@jenlampton jenlampton merged commit ff139c7 into backdrop-ops:gh-pages Jan 9, 2015
@ronnienorwood
Copy link
Contributor Author

Why does the guide need to be regenerated again ??

The table looks good.
I see that the dialog js was taken out of the dialog section. Does the dialog wrapper need to be so tall now ??

@jenlampton
Copy link
Member

The styleguide module is a tool front-end developers use to be sure that they have styled all the elements that come out of Drupal/Backdrop "by default" so that they don't overlook something like system messages, when everything else on a site has been designed & themed.

Here, we used the styleguide module to generate a styleguide for Backdrop itself, so that we can be sure that all the interface elements from the software get a cohesive look/feel in the updated admin theme.

This version of the guide was generated months ago, and we've made some changes to the HTML & CSS in core since then. It's important that everything we have in core is also in our styleguide. (We've added the admin_bar module, for example, and we will need to style the nav bar itself, as well as the drop-down items.)

I do think having multiple columns is a good idea, and as soon as @quicksketch adds the styleguide module to the contrib repository I'd like to recommend that you make those changes there so that we can preserve those layout changes going forward. Plus, everyone else using the styleguide module will benefit the same as us :)

@ronnienorwood
Copy link
Contributor Author

That helps. Sounds good. I will plan to make the changes again after the module comes out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants