758 pspm_expand_epochs #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikbach
reviewed
Sep 30, 2024
src/pspm_expand_epochs.m
Outdated
| @@ -0,0 +1,147 @@ | |||
| function [sts, ep_exp] = pspm_expand_epochs(epoches, expansion, options) | |||
There was a problem hiding this comment.
I would suggest using the varargin syntax.
src/pspm_expand_epochs.m
Outdated
| % Initialize status | ||
| sts = -1; | ||
|
|
||
| % Check if epochs matrix and expansion vector are valid |
There was a problem hiding this comment.
Since this is needed for all modes of the function, I would check it in the beginning of the main function, before anything is loaded from file (faster and easier to read).
src/pspm_expand_epochs.m
Outdated
|
|
||
| % | ||
| % Ensure that the start of any epoch is not negative | ||
| expanded_epochs_temp(expanded_epochs_temp(:,1) < 0, 1) = 0; % or <1??? |
There was a problem hiding this comment.
Probably we should put this code into pspm_get_epochs (if the functionality does not exist there already), because it is needed in several functions.
then just call [sts, epochs] = pspm_get_timing('epochs', epochs)
src/pspm_remove_epochs.m
Outdated
| @@ -12,14 +12,17 @@ | |||
| % be in seconds. This parameter is passed to pspm_get_timing(). | |||
| % * timeunits: timeunits of the epochfile. | |||
| % ┌───options | |||
| % └─.channel_action: | |||
| % └─.channel_action: [pre, post] | |||
There was a problem hiding this comment.
why is the channel action changed?
dominikbach
requested changes
Oct 28, 2024
dominikbach
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758 .
Changes proposed in this pull request: