Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 504 #522

Merged
merged 1 commit into from
Aug 19, 2023
Merged

fix 504 #522

merged 1 commit into from
Aug 19, 2023

Conversation

dominikbach
Copy link
Contributor

Fixes # 504.

Changes proposed in this pull request:

  • changed indexing in pspm_dcm so that when first event in session is at time 0, it won't be excluded.
  • also changed wrong help/comment texts in two places

@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Aug 18, 2023
@dominikbach dominikbach added this to the v6.1 milestone Aug 18, 2023
@dominikbach dominikbach self-assigned this Aug 18, 2023
subs = cellfun(@(x) find(x(1) > subsessions(:,2) & ...
x(2) < (subsessions(:,3)) ...
subs = cellfun(@(x) find(x(1) >= subsessions(:,2) & ...
x(2) <= (subsessions(:,3)) ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I was not aware of this situation when I check the code..

@dominikbach dominikbach merged commit a2ec447 into develop Aug 19, 2023
1 check passed
@dominikbach dominikbach deleted the fix-issue-504 branch August 19, 2023 14:34
@teddychao teddychao added Solved and removed Completed & Waiting for Review Completed and waiting for review labels Aug 20, 2023
@teddychao teddychao removed the Solved label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants