Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 508 #512

Merged
merged 4 commits into from
Aug 11, 2023
Merged

Fix issue 508 #512

merged 4 commits into from
Aug 11, 2023

Conversation

dominikbach
Copy link
Contributor

Fixes # 508.

Changes proposed in this pull request:

  • changes calls to pspm_ecg2hb to pspm_convert_ecg2hb
  • this function was renamed, but the calls weren't

@dominikbach dominikbach added the Completed & Waiting for Review Completed and waiting for review label Aug 11, 2023
@dominikbach dominikbach added this to the v6.1 milestone Aug 11, 2023
@dominikbach dominikbach self-assigned this Aug 11, 2023
@teddychao
Copy link
Contributor

@dominikbach I have checked all the pspm_convert_... functions. Now there are no CFG files that are still using the old names. I have also corrected some code comments.

@teddychao teddychao merged commit ea1efe5 into develop Aug 11, 2023
@teddychao teddychao deleted the fix-issue-508 branch August 11, 2023 22:11
@teddychao teddychao added Solved and removed Completed & Waiting for Review Completed and waiting for review labels Aug 20, 2023
@teddychao teddychao removed the Solved label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teddychao teddychao teddychao approved these changes

Assignees

@dominikbach dominikbach

Labels
None yet
Projects
None yet
Milestone
v6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikbach @teddychao