Rewards

[jrwbabylonlab]

No description provided.

[jrwbabylonlab]

@totraev once your PR is merged which should hopefully contain the latest version of stargate, then i can derive the queryClient directly from the signingStargateClient which we already have above.
The current version of tomo is using an older version of the stargate

[gbarkhatov]

@jrwbabylonlab does it mean that this PR is in Draft/WIP state atm?

[totraev]

@jrwbabylonlab I don't think that instances of QueryClient and SigningStargetClient should be inside CosmosWalletProvider. Instead CosmosWalletProvider just provides factory methods to create such instances somewhere else in the code. CosmosWalletProvider is just a thin adapter for Tomo/Native wallet's network providers to avoid tight coupling between DApp and current wallet provider

[totraev]

any reason why you do this manually instead of using react-query? @jrwbabylonlab

[totraev]

Suggested change

	export const useSigningStargateClient = () => {
	const { signingStargateClient, bech32Address } = useCosmosWallet();
	const simulate = useCallback(
	<T>(msg: { typeUrl: string; value: T }, value: string): Promise<BbnGasFee> => {
	if (!signingStargateClient || !bech32Address) {
	throw new Error("Wallet not connected");
	}
	// estimate gas
	return signingStargateClient.simulate(
	bech32Address,
	[msg],
	value,
	);
	},
	[signingStargateClient, bech32Address],
	);
	return { simulate }
	}

[totraev]

@jrwbabylonlab initialisation of SigningStargetClient can be implemented here. Pass rpc url as param of this hook

[totraev]

Suggested change

	const { signingStargateClient, bech32Address } = useCosmosWallet();
	const { simulate } = useSigningStargateClient();

[totraev]

Suggested change

	const estimateBbnGasFee = useCallback(
	async <T>(msg: { typeUrl: string; value: T }): Promise<BbnGasFee> => {
	if (!signingStargateClient || !bech32Address) {
	throw new Error("Wallet not connected");
	}
	// estimate gas
	const gasEstimate = await signingStargateClient.simulate(
	bech32Address,
	[msg],
	`estimate transaction fee for ${msg.typeUrl}`,
	);
	// TODO: The gas calculation need to be improved
	// https://github.com/babylonlabs-io/simple-staking/issues/320
	const gasWanted = Math.ceil(gasEstimate * 1.5);
	return {
	amount: [{ denom: "ubbn", amount: (gasWanted * 0.01).toFixed(0) }],
	gas: gasWanted.toString(),
	};
	},
	[signingStargateClient, bech32Address],
	);
	const estimateBbnGasFee = useCallback(
	async <T>(msg: { typeUrl: string; value: T }): Promise<BbnGasFee> => {
	// estimate gas
	const gasEstimate = await simulate(
	msg,
	`estimate transaction fee for ${msg.typeUrl}`,
	);
	const gasWanted = Math.ceil(gasEstimate * 1.5);
	return {
	amount: [{ denom: "ubbn", amount: (gasWanted * 0.01).toFixed(0) }],
	gas: gasWanted.toString(),
	};
	},
	[simulate],
	);

[totraev]

Suggested change

	const sendBbnTx = useCallback(
	async <T extends object>(msg: {
	typeUrl: string;
	value: T;
	}): Promise<{ txHash: string; gasUsed: string }> => {
	if (!signingStargateClient || !bech32Address) {
	throw new Error("Wallet not connected");
	}
	// estimate gas
	const fee = await estimateBbnGasFee(msg);
	// sign it
	const res = await signingStargateClient.signAndBroadcast(
	bech32Address,
	[msg],
	fee,
	);
	if (res.code !== 0) {
	throw new Error(
	`Failed to send ${msg.typeUrl} transaction, code: ${res.code}, txHash: ${res.transactionHash}`,
	);
	}
	return {
	txHash: res.transactionHash,
	gasUsed: res.gasUsed.toString(),
	};
	},
	[signingStargateClient, bech32Address, estimateBbnGasFee],
	);
	const sendBbnTx = useCallback(
	async <T extends object>(msg: {
	typeUrl: string;
	value: T;
	}): Promise<{ txHash: string; gasUsed: string }> => {
	// estimate gas
	const fee = await estimateBbnGasFee(msg);
	// sign it
	const res = await simulate(msg, fee,);
	if (res.code !== 0) {
	throw new Error(
	`Failed to send ${msg.typeUrl} transaction, code: ${res.code}, txHash: ${res.transactionHash}`,
	);
	}
	return {
	txHash: res.transactionHash,
	gasUsed: res.gasUsed.toString(),
	};
	},
	[simulate, estimateBbnGasFee],
	);

[totraev]

Too many duplicated code here

[totraev]

@jrwbabylonlab I don't think that instances of QueryClient and SigningStargetClient should be inside CosmosWalletProvider. Instead CosmosWalletProvider just provides factory methods to create such instances somewhere else in the code. CosmosWalletProvider is just a thin adapter for Tomo/Native wallet's network providers to avoid tight coupling between DApp and current wallet provider