Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tong/362 faq #381

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Tong/362 faq #381

merged 6 commits into from
Nov 25, 2024

Conversation

supertong
Copy link
Contributor

Demo:

image

@supertong supertong changed the base branch from v0.3.x to main November 25, 2024 03:23
@supertong supertong mentioned this pull request Nov 25, 2024
Copy link
Contributor

@jeremy-babylonlabs jeremy-babylonlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/app/components/FAQ/FAQ.tsx Outdated Show resolved Hide resolved
@totraev
Copy link
Contributor

totraev commented Nov 25, 2024

Hey @supertong for some reason styles from bbn-core-ui were not added. I've pushed a fix, so you need go through your changes again and update styles

src/app/components/FAQ/Section.tsx Outdated Show resolved Hide resolved
src/app/components/FAQ/Section.tsx Outdated Show resolved Hide resolved
src/app/components/FAQ/data/questions.ts Outdated Show resolved Hide resolved
@totraev totraev merged commit 9f3a099 into main Nov 25, 2024
1 check passed
@totraev totraev deleted the tong/362-faq branch November 25, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants