Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIGENRAND_BUILD_BENCHMARK cmake option #55

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Nov 29, 2023

Hello @bab2min,

Here a PR to turn benchmark building optional.
Today, when using EigenRand as a submodule or with FetchContent, EigenRand benchmark are added to the main project test.
With this PR, we can disable them, and avoid running it.

Thanks !

@ManifoldFR
Copy link
Contributor

Seems there's an #include <cstdio> missing and the build step actually fails (but the CI reports a success) @bab2min

@jorisv
Copy link
Contributor Author

jorisv commented Dec 1, 2023

Hello @bab2min,

All the checks are green except the one on Windows avx512.
I think the Windows agent doesn't support avx512 and then can't run the unit test.

@bab2min
Copy link
Owner

bab2min commented Dec 1, 2023

@jorisv Yes, I think so. It seems to be an error in the CPU running unit test, not an error in the code.
Looks good to me. Thank you for your useful and meaningful contribution.
@ManifoldFR

@bab2min bab2min merged commit 57b92ea into bab2min:main Dec 1, 2023
122 of 124 checks passed
@ManifoldFR
Copy link
Contributor

ManifoldFR commented Dec 1, 2023

Thank you @bab2min !

I didn't forget my issue #53 on adding PDFs/CDFs to the library, sadly I've been sidetracked the past few months so I don't have a PR for that yet but I hope to clear time for that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants