Truncate secret names to prevent going over 63 char limit. #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some secrets created for very long cluster names were going over the
63 char label limit of Kubernetes, and were not deploying.
Example error message:
failureMessage: 'HelmRelease.addons.stackhpc.com "reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack"
is invalid: metadata.labels: Invalid value: "secret.addons.stackhpc.com/reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack-config":
name part must be no more than 63 characters'
|
We also noticed this, and fixed it in the addon provider instead: azimuth-cloud/cluster-api-addon-provider#115 It isn't in a released version yet, but will be soon. |
Thank you @mkjpryor - I'll test and look to update our provider to this instead! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some secrets created for very long cluster names were going over the 63 char label limit of Kubernetes, and were not deploying.
Example error message:
failureMessage: 'HelmRelease.addons.stackhpc.com "reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack"
is invalid: metadata.labels: Invalid value: "secret.addons.stackhpc.com/reallylongnamecluster1reallylo-oe62woigm3qq-ccm-openstack-config":
name part must be no more than 63 characters'