Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORS issue in BinderHub app #19

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Fix CORS issue in BinderHub app #19

merged 1 commit into from
Aug 7, 2024

Conversation

sd109
Copy link
Contributor

@sd109 sd109 commented Aug 6, 2024

Updates BinderHub chart to latest upstream version to fix an issue where the BinderHub app would fail to build images only on HTTPS Azimuth deployments due to CORS errors between the JupyterHub and BinderHub domains. Bug seems to have been fixed upstream so bumping to latest version is sufficient.

Copy link
Collaborator

@mkjpryor mkjpryor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sd109 sd109 merged commit d4a1128 into main Aug 7, 2024
1 check passed
@sd109 sd109 deleted the fix/binderhub-cors branch August 7, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants