Skip to content

Commit

Permalink
Update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
sd109 committed Aug 9, 2024
1 parent 63a5183 commit 05024bd
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions danswer-azimuth/templates/hooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,7 @@ spec:
- pvc
- --all
restartPolicy: Never
# TODO: Is there a better service account to use with profile delete permissions?
# It seems that kubeflow-namespaced SAs can't reach the kube-api-server and
# other SAs in default/kube-system NS can't delete profile resources
# TODO: Create a separate service account
serviceAccountName: default
---
# Until https://github.com/unoplat/vespa-helm-charts/pull/23
Expand Down Expand Up @@ -98,7 +96,5 @@ spec:
- -p
- {{ printf "{'spec':{'template':{'metadata':{'labels':{'app.kubernetes.io/instance':'%s'}}}}}" .Release.Name | replace "'" "\"" | squote }}
restartPolicy: Never
# TODO: Is there a better service account to use with profile delete permissions?
# It seems that kubeflow-namespaced SAs can't reach the kube-api-server and
# other SAs in default/kube-system NS can't delete profile resources
# TODO: Create a separate service account
serviceAccountName: default

0 comments on commit 05024bd

Please sign in to comment.