Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ingress IP optional for HA cluster #240

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Conversation

mkjpryor
Copy link
Collaborator

@mkjpryor mkjpryor commented Dec 4, 2023

This is mainly to be able to do throwaway HA deploys for CI without requiring a certain fixed IP to be free at all times.

@mkjpryor mkjpryor marked this pull request as ready for review December 4, 2023 18:00
@mkjpryor mkjpryor requested a review from a team as a code owner December 4, 2023 18:00
@mkjpryor mkjpryor requested a review from m-bull December 4, 2023 18:05
Copy link
Contributor

@m-bull m-bull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the green tick

@mkjpryor mkjpryor merged commit 520cb10 into main Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants