Add a virtual method "length" on slices, arrays, strings to match JS engines #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Template like "{{ x.length }}" now works with data { x: [ 1, 2, 3 ] }.
This comment has been minimized.
This comment has been minimized.
dolmen
changed the title
|
@aymerick Could you review this change? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
ping @aymerick |
1 similar comment
|
ping @aymerick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JavaScript, all arrays have a property
lengththat returns the length of an array. Mustache/Handlebars engines implemented in JS provide this method on array values and some templates originally designed with such engines rely on it. Example: https://jsfiddle.net/u5d5adsa/17/This patch implements
lengthfor slices and arrays. Template likeLen: {{ x.length }}now works with data{ x: [ 1, 2, 3 ] }=>Len: 3