aya-ebpf: XdpContext adjust_{head|tail|meta} API
#949
Conversation
Added new public API for the `XdpContext`: - `adjust_head` : To grow the packet buffer at the beginning - `adjist_tail` : To grow the packet buffer at the end - `adjust_meta` : To grow metadata area These API are handy for packet processing when additional headers etc. are to be pushed to the packet. Also added these APIs using `cargo xtask public-api --bless` Refs: aya-rs#948
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
mergify
bot
added
aya-bpf
|
I noticed from the comments in the code that passing a negative value can reduce the packet size, which would be very convenient for me. However, passing a negative value to the adjust_head method seems to increase the packet size. Am I missing something, or could there be an issue? Thank you. |
Yes, using the negative value adjust the |
| /// Adjusts the head of the Packet by given 'delta' (both positive and negative values are | ||
| /// possible.) | ||
| #[inline(always)] | ||
| pub fn adjust_head(&mut self, delta: crate::cty::c_int) -> Result<(), ()> { |
There was a problem hiding this comment.
here and in the other methods I think we should use i32, not c_int.
| unsafe { | ||
| match bpf_xdp_adjust_head(self.ctx, delta) { | ||
| 0 => Ok(()), | ||
| _ => Err(()), |
There was a problem hiding this comment.
why not return the error?
Added new public API for the
XdpContext:adjust_head: To grow the packet buffer at the beginningadjist_tail: To grow the packet buffer at the endadjust_meta: To grow metadata areaThese API are handy for packet processing when additional headers etc. are to be pushed to the packet.
Also added these APIs using
cargo xtask public-api --blessRefs: #948
This change is