Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public-api: bless with new nightly #829

Merged
merged 1 commit into from
Nov 1, 2023
Merged

public-api: bless with new nightly #829

merged 1 commit into from
Nov 1, 2023

Conversation

tamird
Copy link
Member

@tamird tamird commented Oct 31, 2023

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6e256fa
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/654123bb6be0e20008cf93c4
😎 Deploy Preview https://deploy-preview-829--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify Mergify
Copy link

mergify bot commented Oct 31, 2023

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

@mergify mergify bot requested a review from alessandrod October 31, 2023 15:57
@mergify mergify bot added api/needs-review Makes an API change that needs review test A PR that improves test cases or CI labels Oct 31, 2023
@tamird tamird requested a review from vadorovsky November 1, 2023 09:08
vadorovsky
vadorovsky approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@vadorovsky vadorovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, so much cleaner!

@tamird tamird merged commit 8647b90 into aya-rs:main Nov 1, 2023
20 checks passed
@tamird tamird deleted the bless-api-nightly branch November 1, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadorovsky vadorovsky vadorovsky approved these changes

@alessandrod alessandrod Awaiting requested review from alessandrod

Assignees
No one assigned
Labels
api/needs-review Makes an API change that needs review test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @vadorovsky