PerfEvent: add option to set the inherit bit #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @alessandrod, this pull request changes the Aya Public API and requires your review. |
mergify
bot
added
api/needs-review
akhramov
force-pushed
the
feature/perf-event-inherit-child
branch
from
0f44f4a to
548c131
Compare
The inherit bit allows extending perf scope to the new child processes.
|
Thanks for the PR!
What does libbpf do? I'm inclined to say we should set inherit=1 by default? |
It doesn't set the bit either.
We can, but it can ruin it for users who don't expect events from the sub-processes. |
|
I see. I think inherit applies to all variants tho right? So maybe it should be an extra bool argument to attach()? |
|
Ping? 😊 |
|
Hey, sorry for the delay. I found my way around this, so probably we should close the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inherit bit allows extending perf scope to the new child processes.
(I am not sure about the API, though)