Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration-test: deflake test_loaded_at #800

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

ajwerner
Copy link
Member

The test could fail due to the lack of clock monotonicity. This PR deflakes the test by adding retries.

See
https://github.com/aya-rs/aya/actions/runs/6340369670/job/17221591723.

@ajwerner ajwerner requested a review from tamird September 28, 2023 17:19
@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for aya-rs-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit da832e4
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/6515ce5881b1c6000884cd46
😎 Deploy Preview https://deploy-preview-800--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the test A PR that improves test cases or CI label Sep 28, 2023
@ajwerner ajwerner force-pushed the deflake-loaded-at-take-2 branch from b685d90 to c6a2ab0 Compare September 28, 2023 17:19
test/integration-test/src/tests/load.rs Outdated Show resolved Hide resolved
test/integration-test/src/tests/load.rs Show resolved Hide resolved
@ajwerner ajwerner force-pushed the deflake-loaded-at-take-2 branch from c6a2ab0 to f844d1e Compare September 28, 2023 19:04
Copy link
Member Author

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR!

test/integration-test/src/tests/load.rs Outdated Show resolved Hide resolved
test/integration-test/src/tests/load.rs Show resolved Hide resolved
The test could fail due to the lack of clock monotonicity. This PR
deflakes the test by adding retries.

See
https://github.com/aya-rs/aya/actions/runs/6340369670/job/17221591723.
@ajwerner ajwerner force-pushed the deflake-loaded-at-take-2 branch from f844d1e to da832e4 Compare September 28, 2023 19:04
@ajwerner ajwerner merged commit c547dd7 into aya-rs:main Sep 28, 2023
20 checks passed
@ajwerner ajwerner deleted the deflake-loaded-at-take-2 branch September 28, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test A PR that improves test cases or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants