Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appease clippy #795

Merged
merged 2 commits into from
Sep 27, 2023
Merged

appease clippy #795

merged 2 commits into from
Sep 27, 2023

Conversation

tamird
Copy link
Member

@tamird tamird commented Sep 27, 2023

  • xtask: appease new clippy warning
  • xtask: remove useless copy

@tamird
xtask: appease new clippy warning
cbe9cd9 
```
warning: unnecessary hashes around raw string literal
  --> xtask/src/docs.rs:70:17
   |
70 |           indoc! {r#"
   |  _________________^
71 | |     User-Agent:*
72 | |     Disallow: /
73 | |     "#},
   | |______^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_raw_string_hashes
   = note: `#[warn(clippy::needless_raw_string_hashes)]` on by default
help: remove all the hashes around the literal
   |
70 ~         indoc! {r"
71 |     User-Agent:*
72 |     Disallow: /
73 ~     "},
   |
```

This false negative was fixed in
rust-lang/rust-clippy#11518 (the title
incorrectly says false positive).
@tamird
xtask: remove useless copy
fe13b2e 
/tmp/initrd.img is unused.
@netlify
Copy link

netlify bot commented Sep 27, 2023 •
edited
Loading

✅ Deploy Preview for aya-rs-docs ready!

Name Link
🔨 Latest commit fe13b2e
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs-docs/deploys/65144cc324dac50008519cc9
😎 Deploy Preview https://deploy-preview-795--aya-rs-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the test A PR that improves test cases or CI label Sep 27, 2023
ajwerner
ajwerner approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tamird tamird merged commit 2f9c67c into main Sep 27, 2023
20 checks passed
@tamird tamird deleted the clippy branch September 27, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajwerner ajwerner ajwerner approved these changes

Assignees
No one assigned
Labels
test A PR that improves test cases or CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamird @ajwerner