Remove MapData::pinned. Make MapData::pin public

[dave-tucker]

This is 2 small changes.

The first removes tracking of whether or not a Map has been pinned from MapData.
This is unnecessary since Maps may be pinned multiple times to multiple locations on a BPF filesystem.

The second change makes MapData::pin part of the public API.
This is to solve a use-case where a user (in this case bpfd) may want to:

• MapData::from_pin to open a pinned map from bpffs
• MapData::pin to pin that object into another bpffs

Both operations should be easily accomplished without needing to cast a MapData into a concrete Map type - e.g aya::maps::HashMap.

---

This change is 

[netlify]

✅ Deploy Preview for aya-rs-docs ready!

Name	Link
🔨 Latest commit	938f979
🔍 Latest deploy log	https://app.netlify.com/sites/aya-rs-docs/deploys/6509ba5da3a7050007392c4b
😎 Deploy Preview	https://deploy-preview-790--aya-rs-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[mergify]

Hey @alessandrod, this pull request changes the Aya Public API and requires your review.

[astoycos]

LGTM

I'll let this merge before continuing on #783 Thanks!

[tamird]

Reviewed 3 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @alessandrod and @dave-tucker)

---

-- commits line 4 at r1:
multiple

Code quote:

mutliple

---

-- commits line 12 at r2:
in the PR description you write

The second change makes MapData::pin part of the public API.
This is to solve a use-case where a user (in this case bpfd) may want to:

• MapData::from_pin to open a pinned map from bpffs
• MapData::pin to pin that object into another bpffs

Both operations should be easily accomplished without needing to cast a MapData into a concrete Map type - e.g aya::maps::HashMap.

Can this rationale be in the commit message too?

---

aya/src/maps/mod.rs line 559 at r1 (raw file):

    pub(crate) fn pin<P: AsRef<Path>>(&mut self, name: &str, path: P) -> Result<(), PinError> {
        use std::os::unix::ffi::OsStrExt as _;

nit: keep this blank line?

---

aya/src/maps/mod.rs line 572 at r2 (raw file):

    pub fn pin<P: AsRef<Path>>(&mut self, path: P) -> Result<(), PinError> {
        use std::os::unix::ffi::OsStrExt as _;
        let path = path.as_ref();

nit: keep this in its old position? or is there a reason it moved?

[dave-tucker]

Comments addressed. Thanks.

Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @alessandrod and @tamird)

---

-- commits line 4 at r1:

Previously, tamird (Tamir Duberstein) wrote…

multiple

Done.

---

-- commits line 12 at r2:

Previously, tamird (Tamir Duberstein) wrote…

in the PR description you write

The second change makes MapData::pin part of the public API.
This is to solve a use-case where a user (in this case bpfd) may want to:

• MapData::from_pin to open a pinned map from bpffs
• MapData::pin to pin that object into another bpffs

Both operations should be easily accomplished without needing to cast a MapData into a concrete Map type - e.g aya::maps::HashMap.

Can this rationale be in the commit message too?

Done.

[tamird]

Reviewed 2 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alessandrod)