Implement XDP Map Types #292
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aya-rs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
This commit adds implementations for: - xskmap - devmap - devmap_hash - cpumap Which can all be used to redirect XDP packets to various different locations Signed-off-by: Dave Tucker <[email protected]>
Signed-off-by: Dave Tucker <[email protected]>
aztecher
added a commit
to aztecher/aya
that referenced
this pull request
Sep 18, 2022
Add BpfLoader::set_max_entries, which sets the max_entries for the specified map, as the load-time option. The max_entries set at map initialization in the ebpf component can be overwritten by this method called on the userspace component. If you want to set max_entries for multiple maps in an ebpf component, you can do so by calling set_max_entries in the form of a method chain. Fixes: aya-rs#308 Refs: aya-rs#292
aztecher
added a commit
to aztecher/aya
that referenced
this pull request
Sep 18, 2022
Add BpfLoader::set_max_entries, which sets the max_entries for the specified map, as the load-time option. The max_entries set at map initialization in the ebpf component can be overwritten by this method called on the userspace component. If you want to set max_entries for multiple maps in an ebpf component, you can do so by calling set_max_entries in the form of a method chain. Fixes: aya-rs#308 Refs: aya-rs#292
aztecher
added a commit
to aztecher/aya
that referenced
this pull request
Sep 19, 2022
Add BpfLoader::set_max_entries, which sets the max_entries for the specified map, as the load-time option. The max_entries set at map initialization in the ebpf component can be overwritten by this method called on the userspace component. If you want to set max_entries for multiple maps in an ebpf component, you can do so by calling set_max_entries in the form of a method chain. Fixes: aya-rs#308 Refs: aya-rs#292
pchaseh
reviewed
Jan 26, 2023
| NonNull::new(value as *mut u32).map(|p| p.as_ref()) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I think that a method such as the following is also necessary, as there's otherwise no way to access the raw map (that I've found) so that bpf_redirect_map can be called by a user of this type
Suggested change
| } | |
| pub unsafe fn redirect(&mut self, key: u64, flags: u64) -> i64 { | |
| bpf_redirect_map( | |
| &mut self.def as *mut _ as *mut _, | |
| key, | |
| flags, | |
| ) | |
| } | |
| } |
There was a problem hiding this comment.
Correct, I just wondered about the "missing" bpf_redirect_map() wrapper myself.
|
Please consider enabling these new maps for use in multi-buffer contexts (via their specific section names), similar to #519. Thanks for your efforts! |
|
Closing in favour of #527 |
mergify
bot
added
aya
|
@dave-tucker, this pull request is now in conflict and requires a rebase. |
Closing for real. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds implementations for:
Which can all be used to redirect XDP packets to various different
locations
TODO:
aya-bpfCloses: #193 #194 #195 #199