-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aya: convert bpf programs to assembly #1000
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for aya-rs-docs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
8c5963d
to
f52b574
Compare
In aya/src/sys/bpf.rs, there are several simple bpf programs written as byte arrays. These need to be adjusted to account for big endian. Already handled in aya-rs#974. Signed-off-by: Billy McFall <[email protected]>
In aya/src/sys/bpf.rs, there are several simple bpf programs written as byte arrays. Rework these as assembly code and then generate the bytecode. Signed-off-by: Billy McFall <[email protected]>
Hello! I don't think we should do this, for two reasons:
|
The issue here is twofold:
If the solana_rbpf assembler is a no-go, that's totally fine. |
something like this works, iirc there's an existing crate for it even |
oh cool! if you find it let me know. |
it's not the one I saw a while ago but this seems ok https://github.com/arcjustin/bpf-ins |
@Billy99, this pull request is now in conflict and requires a rebase. |
In aya/src/sys/bpf.rs, there are several simple bpf programs written as byte arrays. Rework these as assembly code and then generate the bytecode.
This change is