-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Describe a resource #417
Conversation
Warning Rate Limit Exceeded@MdechampG has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 5 minutes and 20 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates introduce comprehensive guides for describing resources, zones, and managing resource governance within the OKP4 Protocol. These guides encompass key creation, credential generation and signing, and blockchain registration, with a focus on secure key management and the procedural steps involved in integrating with the OKP4 blockchain. They also outline the necessity of paying fees in $KNOW for transactions and provide essential templates and tools for users. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 11
Configuration used: CodeRabbit UI
Files selected for processing (3)
- docs/academy/describe-resource.mdx (1 hunks)
- docs/academy/describe-zone.mdx (1 hunks)
- docs/academy/resource-governance.mdx (1 hunks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work that's pretty nice! 🙏
I just noted some suggestions :)
Co-authored-by: Arnaud Mimart <[email protected]>
Co-authored-by: Arnaud Mimart <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docs/academy/describe-resource.mdx (1 hunks)
Additional comments: 5
docs/academy/describe-resource.mdx (5)
- 8-8: The dynamic variable
{readingTime}
is used without explanation or definition. Ensure it is properly defined and calculated, or replace it with a static estimate if dynamic calculation is not implemented.- 43-46: The command to create a new key uses
--keyring-backend test
, which is marked as unsafe for production. Clarify the context in which--keyring-backend test
should be used and provide guidance for a secure keyring setup for production environments.- 241-245: Placeholder text "COMMANDE A AJOUTER" and "AJOUTER RESULTAT" are present, indicating missing content. Replace placeholders with actual commands and expected results to complete the documentation.
- 249-249: The instruction to convert JSON-LD files to N-Quads format links to an external tool without providing an example or further guidance. Include a brief example or additional instructions on converting JSON-LD to N-Quads using the linked tool to improve clarity.
- 235-235: The explanation of signing a verifiable credential is clear and informative. However, ensure consistency in the description of the digital signature's security. The phrase "making it nearly impossible to forge" could be aligned with the suggested improvement for clarity and accuracy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 👍 Just minor remarks.
Co-authored-by: Arnaud Mimart <[email protected]>
Co-authored-by: Arnaud Mimart <[email protected]>
Co-authored-by: Arnaud Mimart <[email protected]>
Co-authored-by: Arnaud Mimart <[email protected]>
Co-authored-by: Chris <[email protected]>
Co-authored-by: Chris <[email protected]>
Co-authored-by: Chris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 13
Configuration used: CodeRabbit UI
Files selected for processing (3)
- docs/academy/describe-resource.mdx (1 hunks)
- docs/academy/resource-governance.mdx (1 hunks)
- docs/academy/zone-governance.mdx (1 hunks)
Co-authored-by: Chris <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great piece ! Thanks 👍
Summary by CodeRabbit