Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/verifiable claims #396

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Feat/verifiable claims #396

merged 9 commits into from
Jan 31, 2024

Conversation

MdechampG
Copy link
Member

@MdechampG MdechampG commented Jan 23, 2024

Add page Verifiable Claims principles in the academy.

Still to do:

  • Add illustrations
  • Add links towards pages that don't exist yet

@ccamel can you please especially review the last part that I changed as we discussed ?

Summary by CodeRabbit

  • Documentation
    • Updated the description of governance and consent rules within the OKP4 protocol to better explain the dynamic nature of blockchain rules.
    • Introduced and detailed the concept of Verifiable Credentials in decentralized identity systems, highlighting their application in the OKP4 protocol and their significance in self-sovereign governance.

@MdechampG MdechampG self-assigned this Jan 23, 2024
Copy link
Contributor

coderabbitai bot commented Jan 23, 2024

Warning

Rate Limit Exceeded

@MdechampG has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 16 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between c729d0f and 501d502.

Walkthrough

The recent updates aim to enhance the understanding of governance and consent within the OKP4 protocol. This involves refining the description of rules and integrating the concept of Verifiable Credentials. The changes highlight the dynamic and complex nature of blockchain rule enforcement and emphasize the pivotal role of Verifiable Credentials in decentralized identity systems, aligning with self-sovereign governance principles and the registration of Verifiable Presentations.

Changes

File Path Change Summary
docs/academy/rules.mdx Modification to clarify the dynamic enforcement of governance and consent rules in the OKP4 protocol.
docs/academy/verifiable-claims.md Introduction of Verifiable Credentials, their role in decentralized identity, and their application in the OKP4 protocol.

🌟 "In the blockchain's deep, where rules dynamically weave,
🐇 A rabbit hops along, in Verifiable Claims to believe.
📜 With each update, a clearer path we achieve,
🌱 Growing stronger in trust, in what we conceive." 🌱

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@MdechampG MdechampG requested a review from ccamel January 23, 2024 16:51
@MdechampG MdechampG marked this pull request as ready for review January 23, 2024 16:51
Copy link
Member

@bot-anik bot-anik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://localhost:3000/

Device URL
mobile http://localhost:3000/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 6

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4f89e67 and 0dabac1.
Files selected for processing (2)
  • docs/academy/rules.mdx (1 hunks)
  • docs/academy/verifiable-claims.md (1 hunks)
Additional comments: 2
docs/academy/rules.mdx (2)
  • 13-20: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The sidebar_class_name: hidden metadata at the top of the file effectively hides the sidebar for this page, ensuring a focused reading experience.

The use of sidebar_class_name: hidden is appropriate for this documentation page.

  • 16-17: The explanation of the OKP4 protocol's rule enforcement mechanism is comprehensive, detailing the complexities involved in managing digital resources and the decision-making processes based on these rules.

The updated description enhances understanding of the protocol's governance and consent rules.

docs/academy/verifiable-claims.md Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/rules.mdx Show resolved Hide resolved
@MdechampG MdechampG force-pushed the feat/verifiable-claims branch from 0dabac1 to f70e57a Compare January 31, 2024 10:27
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 18c305f and f70e57a.
Files selected for processing (2)
  • docs/academy/rules.mdx (1 hunks)
  • docs/academy/verifiable-claims.md (1 hunks)
Files skipped from review as they are similar to previous changes (2)
  • docs/academy/rules.mdx
  • docs/academy/verifiable-claims.md

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great. ☺️ A few other minor comments to take into account as you wish.

docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
docs/academy/verifiable-claims.md Show resolved Hide resolved
docs/academy/verifiable-claims.md Outdated Show resolved Hide resolved
MdechampG and others added 2 commits January 31, 2024 15:41
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f70e57a and c729d0f.
Files selected for processing (1)
  • docs/academy/verifiable-claims.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • docs/academy/verifiable-claims.md

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 👍

@MdechampG MdechampG merged commit 2072b55 into main Jan 31, 2024
12 checks passed
@MdechampG MdechampG deleted the feat/verifiable-claims branch January 31, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants