-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: token model v2 #356
feat: token model v2 #356
Conversation
WalkthroughThe recent updates involve a comprehensive overhaul of the token model's documentation and visualization code. The changes include renaming modules and data structures, refining the token model's description, and altering the calculation logic to reflect a new inflation formula and its impact on the token economy. Changes
TipsChat with CodeRabbit Bot (
|
0cb0ca9
to
0532c27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
0532c27
to
668b672
Compare
668b672
to
17de574
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (2)
- docs/whitepaper/token-model.mdx (2 hunks)
- docs/whitepaper/token-model.tsx (2 hunks)
Additional comments: 6
docs/whitepaper/token-model.mdx (2)
- 5-5: The import statement should be updated to reflect the new module name as per the PR objectives and summary.
- import { inflationRateData, srdyPercentData, LinePlot } from './token-model' + import { inflationRateData, srdyPercentData, LinePlot } from './inflationRateData'
- 19-73: The updates to the documentation in this hunk are consistent with the PR objectives and the summary provided, reflecting the new "KNOW Token Model" and its mechanisms.
docs/whitepaper/token-model.tsx (4)
5-5: The introduction of the new constant
c
is in line with the PR objectives and the summary provided.9-14: The
inflationPoints
generator function has been correctly implemented to reflect the new calculation logic for the inflation rate.17-23: The
inflationRateData
data structure has been updated to use the newinflationPoints
function, which is consistent with the PR objectives and the summary.81-81: The use of the constant
c
as a marker value in theLinePlot
component is consistent with the changes made to the token model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😉
Specification of the token model v2 for the OKP4 protocol by @tpelliet.
Summary by CodeRabbit
Documentation
Refactor
Style