Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Nodes & Validators) Some basic edits & additional commands #132

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Errorist79
Copy link

@Errorist79 Errorist79 commented Oct 11, 2022

revised:

simple additions

  • start node with systemd
  • Using regex to add peers
  • additional helpful commands

Please let me know any points that i missed, or that you think should not be.

@ccamel
Copy link
Member

ccamel commented Oct 14, 2022

Hi @Errorist79! Thanks for contributing.

Some workflows of the CI has failed. if you don't mind, could you please:

  • fix the commits messages to respect the conventional commit formalism (see okp4/wiki/Naming-rules#commit-messages),
  • check that the markdown files follows the standard enforced by markdownlint. You can invoke yarn lint to verify that the linter passes. And the yarn lint:fix command should fix the majority of the issues.

We can assist you if needed. Thx ☺️

@ccamel ccamel marked this pull request as draft October 14, 2022 20:23
@Errorist79
Copy link
Author

Errorist79 commented Oct 17, 2022

Hi @Errorist79! Thanks for contributing.

Some workflows of the CI has failed. if you don't mind, could you please:

  • fix the commits messages to respect the conventional commit formalism (see okp4/wiki/Naming-rules#commit-messages),
  • check that the markdown files follows the standard enforced by markdownlint. You can invoke yarn lint to verify that the linter passes. And the yarn lint:fix command should fix the majority of the issues.

We can assist you if needed. Thx ☺️

Thanks! sorry for that.
hating conventional commit formalisms 😄 added backlog rn, can raise a new PR later🙏🏻

@Errorist79 Errorist79 marked this pull request as ready for review October 17, 2022 01:16
@ccamel ccamel force-pushed the main branch 2 times, most recently from 4be57ee to 681b30d Compare October 29, 2022 06:10
@fredericvilcot
Copy link
Contributor

@ccamel
What about this PR?
I think we shouldn't leave PRs open for too long, let me know 😌

@ccamel
Copy link
Member

ccamel commented Dec 2, 2022

Yes, we agree 😌 We shouldn't make the PR open for too long.

For this one, the PR now conflicts. And we have to check with @amimart for the content. Some things may have changed since the launch of Nemeton.

@ccamel ccamel force-pushed the main branch 4 times, most recently from 777dbc2 to 54d7bdc Compare November 21, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants