Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAPROXY] use $SOURCEIP instead of $PROXIED_SRCIP #361

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

bazsi
Copy link
Member

@bazsi bazsi commented Nov 2, 2024

This is an incompatible change, but the old behaviour is rather confusing and difficult to use. The incompatiblity only
affects connections that are coming via a proxy. In that case $PROXIED_SRCIP and friends are not going to be set,
but $SOURCEIP, $DESTIP and $DESTPORT will be present instead.

@bazsi bazsi force-pushed the haproxy-use-sourceip-instead-of-proxied-srcip branch 2 times, most recently from cdfd3b6 to c2c1e8f Compare November 2, 2024 21:09
@bazsi bazsi force-pushed the haproxy-use-sourceip-instead-of-proxied-srcip branch 3 times, most recently from 536951a to 58f020f Compare November 9, 2024 20:51
Copy link
Contributor

github-actions bot commented Nov 9, 2024

This Pull Request introduces config grammar changes

axoflow/9d25570002aaa3c97d7275d119270bd68a6b45d2 -> bazsi/haproxy-use-sourceip-instead-of-proxied-srcip

--- a/destination
+++ b/destination

 network(
     transport(
+        auto
     )
 )

 syslog(
     transport(
+        auto
     )
 )

--- a/source
+++ b/source

 network(
     transport(
+        auto
     )
 )

 syslog(
     transport(
+        auto
     )
 )

@bazsi bazsi force-pushed the haproxy-use-sourceip-instead-of-proxied-srcip branch from 58f020f to dff7494 Compare November 11, 2024 19:51
bazsi added 21 commits December 3, 2024 12:59
…ogTransport instances

Signed-off-by: Balazs Scheidler <[email protected]>
This is just the change in test code, which adds LogProtoServer ** arguments
to the handshake related functions, in order to allow
log_proto_server_handshake to change the LogProto instance.

Signed-off-by: Balazs Scheidler <[email protected]>
This can be used to simplify LogProtoAutoServer.

Signed-off-by: Balazs Scheidler <[email protected]>
Signed-off-by: Balazs Scheidler <[email protected]>
…instance

Instead of going to the fd directly, wrap the lower-level LogTransport
instance into a BIO and use that. This implements proper stacking
for LogTransportTLS.

Signed-off-by: Balazs Scheidler <[email protected]>
Instead of using proxy protocol specific name value pairs, set the
addresses in the message's saddr/daddr members.

This should be a lot faster and a lot easier to use.

Signed-off-by: Balazs Scheidler <[email protected]>
@bazsi bazsi force-pushed the haproxy-use-sourceip-instead-of-proxied-srcip branch from dff7494 to 672e0c2 Compare December 3, 2024 17:15
@bazsi bazsi force-pushed the haproxy-use-sourceip-instead-of-proxied-srcip branch from 672e0c2 to 1c9e896 Compare December 3, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant