Support custom github runners (and arm64) #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesj
commented
Nov 28, 2023
milesj
commented
Nov 28, 2023
milesj
commented
Nov 28, 2023
milesj
changed the title
mistydemeo
requested changes
Nov 28, 2023
|
Thank you! I'm going to do some testing, but this looks good. A couple minor requests:
|
milesj
changed the title
|
@mistydemeo Updated. Also added a test, but not sure if done correctly. I also tried updating snapshots, but it changed like almost all of them... |
|
@mistydemeo Got the test working. |
|
Great, thank you! I'll do some testing and then merge. |
|
Awesome 👏 |
|
This has landed in the 0.6.0 prereleases, which are ready to try now, and will be in the final 0.6.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirectly implements: #324
I really need linux arm64 support soon, so I thought I would give this a shot.
I originally had a setting like
arm64-linux-runnerthat I would use for linux arm64 triples, but it felt very restrictive. Instead, I went with acustom-runnersmap, that allows any triple to define the runner it wants to use. This is nice.Working in plan/manifest:
