Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cleanup github releases / ci contents #596

Merged
merged 10 commits into from
Nov 22, 2023
Merged

feat: cleanup github releases / ci contents #596

merged 10 commits into from
Nov 22, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Nov 21, 2023 •
edited
Loading

Kind of a grab-bag:

  • rename tasks to match the conceptual model now that it's real
    • should-publish => host
    • announce-release/publish-release => announce
  • clean up comments, add another test
  • create an empty Release for a library-release, allowing everything to know it should be hosted/published/announced
    • in theory this means library-releases to axo hosting should Now Work, but, not yet tested
  • github Releases now get the pretty Release urls from axo hosting
    • when performing host --steps=release we will update the artifact download urls with the result
      • only the axodotdev url will be updated, if github hosting also is enabled it will still refer to the github release
      • but we prefer the axodotdev url in multi-host-drifting so that's mostly academic
      • we also will find-and-replace the artifact download url in all install_hints
      • we will also regenerate the github releases announcement body to include the new hints
    • in CI we now save the dist-manifest at the end of the host job (which includes --steps=release)
      • it is written back to scratch storage (but not persistent storage on Abyss, which is logically Frozen at that point)
        • this propagates the updated URLs to announce/publish steps
        • this is actually technically Useless in the current impl but I'm sure we'll want it later so let's just do it now
      • it is saved to an output of the host step in the same way the dist-manifest of "plan" is
    • in CI we now have the github announcement read from host.val instead of plan.val to get the new release notes
  • PR includes prereleases 7, 8, and 9 for testing

@Gankra
Copy link
Contributor Author

Gankra commented Nov 22, 2023

cut pre7 on this branch, and used it to make this release:

https://github.com/Gankra/evil-workspace/releases/tag/v0.8.3

@Gankra Gankra changed the title feat: make github release bodies prettier feat: cleanup github releases / ci contents Nov 22, 2023
@Gankra
Copy link
Contributor Author

Gankra commented Nov 22, 2023

updated first comment to explain wtf i've done in here

mistydemeo
mistydemeo approved these changes Nov 22, 2023
View reviewed changes
cargo-dist/tests/snapshots/lib_manifest.snap
@@ -24,5 +35,4 @@ stdout:
}

stderr:
WARN You're trying to explicitly Release a library, only minimal functionality will work
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not want this message anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah i think it's fine to drop it, since this PR makes it work... More.

@Gankra Gankra merged commit 99cc165 into main Nov 22, 2023
14 checks passed
@Gankra Gankra deleted the late-announce branch November 22, 2023 20:58
@Gankra Gankra mentioned this pull request Nov 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mistydemeo mistydemeo mistydemeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gankra @mistydemeo @fasterthanlime