feat(installer): add additional shell config #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
commented
Nov 8, 2023
Gankra
approved these changes
Nov 8, 2023
mistydemeo
force-pushed
the
installer_source_targets
branch
4 times, most recently
from
26a1535 to
f90ea74
Compare
~/.profile isn't sourced in many circumstances; we need to write this to a large number of locations to make sure it gets considered by bash and zsh under the largest number of circumstances. We have three sets of configuration files, covering generic POSIX, bash, and zsh. We pick the first file that exists in each set, and if none exists, we create the first in the list. Fixes #547.
mistydemeo
force-pushed
the
installer_source_targets
branch
2 times, most recently
from
00fd938 to
a96bcc7
Compare
mistydemeo
force-pushed
the
installer_source_targets
branch
4 times, most recently
from
3155bbf to
5ed9108
Compare
Gankra
approved these changes
Dec 4, 2023
mistydemeo
force-pushed
the
installer_source_targets
branch
4 times, most recently
from
04151f4 to
add2143
Compare
mistydemeo
force-pushed
the
installer_source_targets
branch
from
add2143 to
90ca70d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~/.profile isn't sourced in many circumstances; we need to write this to a large number of locations to make sure it gets considered by bash and zsh under the largest number of circumstances.
Fixes #547.