-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(init): various fixes/improvements #437
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if you have Github CI enabled, we won't ask anymore * if you have pr-run-mode set, we won't ask anymore (we also no longer omit it from output when the default is selected, so that we can distinguish new init from made-a-decision) * extra unimportant words removed * if you have no CI backend enabled we will still allow you to turn on msi * we will always run generate at the end (unless --no-generate-ci is set) because generate now detects which parts need to run on its own (and the current logic was preventing CI-less MSI from working).
Gankra
force-pushed
the
init-targets
branch
from
September 21, 2023 13:50
594aaef
to
1647feb
Compare
Gankra
changed the title
feat(init): add target menu to init
feat(init): various fixes/improvements
Sep 21, 2023
mistydemeo
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, confirmed working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[profile]
de-emphasized, sent to the end, not mentioned if unchanged