Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(init): various fixes/improvements #437

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feat(init): various fixes/improvements #437

merged 4 commits into from
Sep 21, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Sep 18, 2023

  • new target selection UI
  • if you have Github CI enabled, we won't ask anymore
  • if you have pr-run-mode set, we won't ask anymore (we also no longer omit it from output when the default is selected, so that we can distinguish new init from made-a-decision)
  • extra unimportant words removed
  • if you have no CI backend enabled we will still allow you to turn on msi
  • we will always run generate at the end (unless --no-generate-ci is set) because generate now detects which parts need to run on its own (and the current logic was preventing CI-less MSI from working).
  • [profile] de-emphasized, sent to the end, not mentioned if unchanged

@Gankra Gankra added this to the 0.3.0 milestone Sep 20, 2023
@Gankra Gankra self-assigned this Sep 20, 2023
@Gankra
Copy link
Contributor Author

Gankra commented Sep 21, 2023

Here are some screenshots of the 3 main init workflows. Each screenshot is a spot where your are stopped to make a decision. The displayed value is the the one --yes would have selected. I always press enter, getting the same result as --yes.

First Init Workflow

This is a True Init, where cargo-dist wasn't setup at all.

image
image
image
image

final output:
image

Upgrade Workflow

This is someone running cargo dist init to update to a new version of cargo-dist. In this case they are prompted to setup the new pr-run-mode feature:

image
image
image
image

final output:
image

Up To Date Workflow

This is someone running cargo dist init with an up to date cargo-dist. In this case they're either looking to change targets/installers, or just want to run generate.

image
image

final output:
image

* if you have Github CI enabled, we won't ask anymore
* if you have pr-run-mode set, we won't ask anymore (we also no longer omit it from output when the default is selected, so that we can distinguish new init from made-a-decision)
* extra unimportant words removed
* if you have no CI backend enabled we will still allow you to turn on msi
* we will always run generate at the end (unless --no-generate-ci is set) because generate now detects which parts need to run on its own (and the current logic was preventing CI-less MSI from working).
@Gankra
Copy link
Contributor Author

Gankra commented Sep 21, 2023

Got tired of seeing the [profile] stuff so prominently, so I removed it completely from the top, and now have it only show up if it's being made for the first time:

First Init

image

Update / Up To Date

image

@Gankra Gankra changed the title feat(init): add target menu to init feat(init): various fixes/improvements Sep 21, 2023
@Gankra Gankra marked this pull request as ready for review September 21, 2023 14:04
Copy link
Contributor

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, confirmed working

@Gankra Gankra merged commit e7abba6 into main Sep 21, 2023
14 checks passed
@Gankra Gankra deleted the init-targets branch September 21, 2023 19:31
@Gankra Gankra mentioned this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants