feat(windows-sign): add unstable ssl.com windows signing #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
main outstanding question is names of the SECRETS which I made up and don't match ssl.com's defaults. They use ES_USERNAME, ES_PASSWORD, CREDENTIAL_ID, and ES_TOTP_SECRET ("es" is "esign"). |
mistydemeo
approved these changes
Sep 14, 2023
| {{%- if global_task %}} | ||
| - upload-global-artifacts | ||
| {{%- endif %}} | ||
| runs-on: "ubuntu-20.04" |
There was a problem hiding this comment.
Nice we can run it on not-Windows.
There was a problem hiding this comment.
yeah it's pure java, running it on windows is actually harder (they ship the whole jvm x3)
| uses: sslcom/esigner-codesign@develop | ||
| with: | ||
| command: batch_sign | ||
| username: ${{ secrets.SSL_CODESIGN_USER }} |
There was a problem hiding this comment.
I think using an SSLCOM prefix would make this a little clearer to me.
There was a problem hiding this comment.
I changed everything to SSLDOTCOM/ssldotcom prefixes (matches how we treat axo.dev) and made these match a bit more with the action's defaults.
Gankra
force-pushed
the
secret-sign
branch
3 times, most recently
from
73fcbff to
6af290a
Compare
ssldotcom-windows-sign=true
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.