Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check for shadowed binaries in shell installer #1659

Merged
merged 1 commit into from
Dec 20, 2024
Merged

feat: check for shadowed binaries in shell installer #1659

merged 1 commit into from
Dec 20, 2024

Conversation

mistydemeo
Copy link
Contributor

This was a user request. In some cases, the user may have multiple copies of something installed, and won't realize the copy installed by the shell installer has been shadowed in their PATH. It's useful for us to test that and provide an explicit warning.

Tested and working:

$ ./axolotlsay-installer.sh
downloading axolotlsay 0.2.320 aarch64-apple-darwin
installing to /Users/mistydemeo/.cargo/bin
  axolotlsay
  axolotlsay-update
everything's installed!
WARNING: The following commands are shadowed by other commands in your PATH: axolotlsay

duckinator
duckinator approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@duckinator duckinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and it works well.

@duckinator duckinator merged commit c158b7d into main Dec 20, 2024
18 checks passed
@duckinator duckinator deleted the warn-shadowed-path branch December 20, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckinator duckinator duckinator approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mistydemeo @duckinator