feat: update axoupdater, fetch known-good version #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckinator
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
This seems like a good improvement to me! As you mentioned in #1598 (comment), it seems prudent to avoid breaking changes happening where we don't expect them.
mistydemeo
force-pushed
the
update-axoupdater
branch
from
bd7431a to
71c7a14
Compare
|
Added an off-by-default option to always use the latest axoupdater. |
mistydemeo
force-pushed
the
update-axoupdater
branch
from
71c7a14 to
e86874c
Compare
Instead of always fetching the latest axoupdater, fetch the version that this version of dist itself uses as a library. That way, we're always fetching something predictable.
mistydemeo
force-pushed
the
update-axoupdater
branch
2 times, most recently
from
1938e55 to
00d2a08
Compare
|
Confirmed the flag works - build with the flag fetching the And build without fetching the fixed version: https://github.com/mistydemeo/cargodisttest/actions/runs/12383684253/job/34566994890#step:9:77 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of always fetching the latest axoupdater, fetch the version that this version of dist itself uses as a library. That way, we're always fetching something predictable.