-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add logRequestDetails
option to withAxiomRouteHandler
#243
feat: Add logRequestDetails
option to withAxiomRouteHandler
#243
Conversation
@gabrielelpidio is attempting to deploy a commit to the AxiomFM Team on Vercel. A member of the Team first needs to authorize it. |
546a84a
to
7047c13
Compare
Deployment failed with the following error:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Some small docs suggestions included.
Significant topic: I am not sure details
is the best name for this api. Won't block on that, but maybe ask someone else for their opinion on this. I would suggest something along the lines of include(Req|Request)
, log(Req|Request)
but not 100% on those suggestions either.
details
option to withAxiomRouteHandlerlogReq
option to withAxiomRouteHandler
… to 'details' in RequestReport
logReq
option to withAxiomRouteHandlerlogRequestDetails
option to withAxiomRouteHandler
This PR introduces an optional configuration object that contains a
logRequestDetails
property to specify if and whether to include detailed request information.Example of usage
or