feat(client): drop retry/backoff functionality #294
+7
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rambatino
reviewed
Apr 5, 2024
lukasmalkmus
force-pushed
the
lukasmalkmus/drop-retry
branch
from
bca2b10
to
ca9608c
Compare
lukasmalkmus
force-pushed
the
lukasmalkmus/drop-retry
branch
from
ca9608c
to
10c49d6
Compare
lukasmalkmus
commented
Apr 15, 2024
| _ = resp.Body.Close() | ||
|
|
||
| // Reset the requests body, so it can be re-read. | ||
| if req.Body, err = req.GetBody(); err != nil { |
There was a problem hiding this comment.
I think we should also drop any code that sets GetBody.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.