Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(nexus)!: distinguish locking of bank coin vs nexus assets #2197

Closed
wants to merge 1 commit into from
Closed

refactor(nexus)!: distinguish locking of bank coin vs nexus assets #2197

wants to merge 1 commit into from

Conversation

milapsheth
Copy link
Member

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues
  • Tag type of change
  • Upgrade handler

Steps to Test

Expected Behaviour

Other Notes

@milapsheth
Copy link
Member Author

As per discussion, closed the refactor for now until we think of a cleaner way to separate the two scenarios. Added back the validation check in #2198

@milapsheth milapsheth closed this Oct 17, 2024
@milapsheth milapsheth deleted the refactor/lockable-asset branch October 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@milapsheth